ionos-cloud / terraform-provider-profitbricks

Terraform ProfitBricks provider
https://www.terraform.io/docs/providers/profitbricks/
Mozilla Public License 2.0
3 stars 16 forks source link

Fix conflicting auth token default value #47

Closed Ntr0 closed 5 years ago

Ntr0 commented 5 years ago

Fixes: #46

schegi commented 5 years ago

make testacc output:

==> Checking that code complies with gofmt requirements... TF_ACC=1 go test $(go list ./... |grep -v 'vendor') -v -timeout 120m ? github.com/terraform-providers/terraform-provider-profitbricks [no test files] === RUN TestAccDataSourceDatacenter_matching --- PASS: TestAccDataSourceDatacenter_matching (36.21s) === RUN TestAccDataSourceImage_basic --- PASS: TestAccDataSourceImage_basic (4.06s) === RUN TestAccDataSourceLocation_basic --- PASS: TestAccDataSourceLocation_basic (1.24s) === RUN TestAccResource_basic --- PASS: TestAccResource_basic (24.08s) === RUN TestAccProfitBricksDataCenter_ImportBasic --- PASS: TestAccProfitBricksDataCenter_ImportBasic (23.86s) === RUN TestAccProfitBricksFirewall_ImportBasic --- PASS: TestAccProfitBricksFirewall_ImportBasic (364.16s) === RUN TestAccProfitBricksIPBlock_ImportBasic --- PASS: TestAccProfitBricksIPBlock_ImportBasic (24.38s) === RUN TestAccProfitBricksLan_ImportBasic --- PASS: TestAccProfitBricksLan_ImportBasic (47.46s) === RUN TestAccProfitBricksNic_ImportBasic --- PASS: TestAccProfitBricksNic_ImportBasic (304.10s) === RUN TestAccProfitBricksServer_ImportBasic --- PASS: TestAccProfitBricksServer_ImportBasic (301.45s) === RUN TestProvider --- PASS: TestProvider (0.00s) === RUN TestProvider_impl --- PASS: TestProvider_impl (0.00s) === RUN TestAccProfitBricksDataCenter_Basic --- PASS: TestAccProfitBricksDataCenter_Basic (49.61s) === RUN TestAccProfitBricksFirewall_Basic --- PASS: TestAccProfitBricksFirewall_Basic (339.27s) === RUN TestAccProfitBricksGroup_Basic --- FAIL: TestAccProfitBricksGroup_Basic (0.14s) testing.go:518: Step 0 error: Error applying: 1 error(s) occurred:

    * profitbricks_group.group: 1 error(s) occurred:

    * profitbricks_group.group: An error occured while creating a group: HTTP Status: 403
    Error Messages:Error Code: 312 Message: Access Denied as you need CREATE_GROUP privilege for this operation

=== RUN TestAccProfitBricksIPBlock_Basic --- PASS: TestAccProfitBricksIPBlock_Basic (26.29s) === RUN TestAccProfitBricksLanIPFailover_Basic --- PASS: TestAccProfitBricksLanIPFailover_Basic (367.03s) === RUN TestAccProfitBricksLan_Basic --- PASS: TestAccProfitBricksLan_Basic (62.82s) === RUN TestAccProfitBricksLoadbalancer_Basic --- FAIL: TestAccProfitBricksLoadbalancer_Basic (395.58s) testing.go:518: Step 0 error: After applying this step, the plan was not empty:

    DIFF:

    UPDATE: profitbricks_loadbalancer.example
      ip: "10.11.112.226" => ""

    STATE:

    profitbricks_datacenter.foobar:
      ID = c1f80d53-f293-4cfd-8db9-94e282b3554f
      provider = provider.profitbricks
      description =
      location = us/las
      name = loadbalancer-test
    profitbricks_loadbalancer.example:
      ID = 7675c3df-f5b4-4020-88a0-085f7a1904fc
      provider = provider.profitbricks
      datacenter_id = c1f80d53-f293-4cfd-8db9-94e282b3554f
      dhcp = true
      ip = 10.11.112.226
      name = loadbalancer
      nic_ids.# = 1
      nic_ids.0 = e56e4872-2714-4a4c-bdd4-e28beee37f6c

      Dependencies:
        profitbricks_datacenter.foobar
        profitbricks_nic.database_nic
    profitbricks_nic.database_nic:
      ID = e56e4872-2714-4a4c-bdd4-e28beee37f6c
      provider = provider.profitbricks
      datacenter_id = c1f80d53-f293-4cfd-8db9-94e282b3554f
      dhcp = true
      firewall_active = true
      ips.# = 1
      ips.0 = 10.8.232.11
      lan = 2
      name = updated
      server_id = 1ab5aa5f-15f5-4b50-aaa0-3c6aad162c0a

      Dependencies:
        profitbricks_datacenter.foobar
        profitbricks_server.webserver
    profitbricks_server.webserver:
      ID = 1ab5aa5f-15f5-4b50-aaa0-3c6aad162c0a
      provider = provider.profitbricks
      availability_zone = ZONE_1
      boot_volume = 9b6984f7-1f54-44e4-b25f-04907c2002cb
      cores = 1
      cpu_family = AMD_OPTERON
      datacenter_id = c1f80d53-f293-4cfd-8db9-94e282b3554f
      image_name = ubuntu-16.04
      image_password = K3tTj8G14a3EgKyNeeiY
      name = webserver
      nic.# = 1
      nic.0.dhcp = true
      nic.0.firewall.# = 0
      nic.0.firewall_active = true
      nic.0.ip = 10.9.108.11
      nic.0.ips.# = 1
      nic.0.ips.0 = 10.9.108.11
      nic.0.lan = 1
      nic.0.name =
      nic.0.nat = false
      primary_ip = 10.9.108.11
      primary_nic = 4e908e78-929e-4118-9501-968a5cd5142f
      ram = 1024
      ssh_key_path.# = 0
      volume.# = 1
      volume.0.availability_zone = AUTO
      volume.0.bus = VIRTIO
      volume.0.disk_type = SSD
      volume.0.image_aliases.# = 0
      volume.0.image_name =
      volume.0.image_password =
      volume.0.licence_type = LINUX
      volume.0.name = system
      volume.0.size = 5
      volume.0.ssh_key_path.# = 0

      Dependencies:
        profitbricks_datacenter.foobar

=== RUN TestAccProfitBricksNic_Basic --- PASS: TestAccProfitBricksNic_Basic (328.52s) === RUN TestAccProfitBricksServer_Basic --- PASS: TestAccProfitBricksServer_Basic (333.86s) === RUN TestAccProfitBricksShare_Basic --- FAIL: TestAccProfitBricksShare_Basic (23.74s) testing.go:518: Step 0 error: Error applying: 1 error(s) occurred:

    * profitbricks_group.group: 1 error(s) occurred:

    * profitbricks_group.group: An error occured while creating a group: HTTP Status: 403
    Error Messages:Error Code: 312 Message: Access Denied as you need CREATE_GROUP privilege for this operation

testing.go:579: Error destroying resource! WARNING: Dangling resources
    may exist. The full state and error is shown below.

    Error: Check failed: share for resource  still exists in group

    State: <no state>

=== RUN TestAccProfitBricksSnapshot_Basic --- PASS: TestAccProfitBricksSnapshot_Basic (362.41s) === RUN TestAccProfitBricksUser_Basic --- FAIL: TestAccProfitBricksUser_Basic (0.52s) testing.go:518: Step 0 error: Error applying: 2 error(s) occurred:

    * profitbricks_user.user: 1 error(s) occurred:

    * profitbricks_user.user: An error occured while creating a user: HTTP Status: 403
    Error Messages:Error Code: 312 Message: Access Denied as you need ADMIN privilege for this operation

    * profitbricks_group.group: 1 error(s) occurred:

    * profitbricks_group.group: An error occured while creating a group: HTTP Status: 403
    Error Messages:Error Code: 312 Message: Access Denied as you need CREATE_GROUP privilege for this operation

=== RUN TestAccProfitBricksVolume_Basic --- PASS: TestAccProfitBricksVolume_Basic (404.19s) FAIL FAIL github.com/terraform-providers/terraform-provider-profitbricks/profitbricks 3824.996s make: *** [testacc] Error 1

Again, TestAccProfitBricksUser_Basic, TestAccProfitBricksShare_Basic and TestAccProfitBricksGroup_Basic fail due to missing CREATE_GROUP privilege and TestAccProfitBricksLoadbalancer_Basic fails anyway.

jasmingacic commented 5 years ago

@Ntr0 can you please update the change log so i can merge this.

jasmingacic commented 5 years ago

@Ntr0 the CI is failing can you take care of that.