ionos-cloud / terraform-provider-profitbricks

Terraform ProfitBricks provider
https://www.terraform.io/docs/providers/profitbricks/
Mozilla Public License 2.0
3 stars 16 forks source link

Set cpu_family to computed. #54

Closed Ntr0 closed 5 years ago

Ntr0 commented 5 years ago

Setting no value for cpu family will use the location's default, but would trigger an unrequired change on plans later on.

Ntr0 commented 5 years ago

make testacc:

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test $(go list ./... |grep -v 'vendor') -v  -timeout 120m
?       github.com/terraform-providers/terraform-provider-profitbricks  [no test files]
=== RUN   TestAccDataSourceDatacenter_matching
--- PASS: TestAccDataSourceDatacenter_matching (27.99s)
=== RUN   TestAccDataSourceImage_basic
--- PASS: TestAccDataSourceImage_basic (1.77s)
=== RUN   TestAccDataSourceLocation_basic
--- PASS: TestAccDataSourceLocation_basic (1.00s)
=== RUN   TestAccResource_basic
--- PASS: TestAccResource_basic (105.10s)
=== RUN   TestAccProfitBricksDataCenter_ImportBasic
--- PASS: TestAccProfitBricksDataCenter_ImportBasic (22.49s)
=== RUN   TestAccProfitBricksFirewall_ImportBasic
--- PASS: TestAccProfitBricksFirewall_ImportBasic (321.01s)
=== RUN   TestAccProfitBricksIPBlock_ImportBasic
--- PASS: TestAccProfitBricksIPBlock_ImportBasic (23.00s)
=== RUN   TestAccProfitBricksLan_ImportBasic
--- PASS: TestAccProfitBricksLan_ImportBasic (44.92s)
=== RUN   TestAccProfitBricksNic_ImportBasic
--- PASS: TestAccProfitBricksNic_ImportBasic (297.57s)
=== RUN   TestAccProfitBricksServer_ImportBasic
--- PASS: TestAccProfitBricksServer_ImportBasic (320.83s)
=== RUN   TestProvider
--- PASS: TestProvider (0.00s)
=== RUN   TestProvider_impl
--- PASS: TestProvider_impl (0.00s)
=== RUN   TestAccProfitBricksDataCenter_Basic
--- PASS: TestAccProfitBricksDataCenter_Basic (45.50s)
=== RUN   TestAccProfitBricksFirewall_Basic
--- PASS: TestAccProfitBricksFirewall_Basic (393.54s)
=== RUN   TestAccProfitBricksGroup_Basic
--- PASS: TestAccProfitBricksGroup_Basic (45.12s)
=== RUN   TestAccProfitBricksIPBlock_Basic
--- PASS: TestAccProfitBricksIPBlock_Basic (32.00s)
=== RUN   TestAccProfitBricksLanIPFailover_Basic
--- PASS: TestAccProfitBricksLanIPFailover_Basic (398.53s)
=== RUN   TestAccProfitBricksLan_Basic
--- PASS: TestAccProfitBricksLan_Basic (84.40s)
=== RUN   TestAccProfitBricksLoadbalancer_Basic
--- FAIL: TestAccProfitBricksLoadbalancer_Basic (327.83s)
    testing.go:518: Step 0 error: After applying this step, the plan was not empty:

        DIFF:

        UPDATE: profitbricks_loadbalancer.example
          ip: "10.13.142.226" => ""

        STATE:

        profitbricks_datacenter.foobar:
          ID = 4a709c1e-1ace-448e-81ce-c66aa565bed2
          provider = provider.profitbricks
          description = 
          location = us/las
          name = loadbalancer-test
        profitbricks_loadbalancer.example:
          ID = e217a8da-f3a7-41d9-9aff-7cc4d67d3196
          provider = provider.profitbricks
          datacenter_id = 4a709c1e-1ace-448e-81ce-c66aa565bed2
          dhcp = true
          ip = 10.13.142.226
          name = loadbalancer
          nic_ids.# = 1
          nic_ids.0 = 0ea56c50-5c80-47f4-a1c3-065f1345b3a6

          Dependencies:
            profitbricks_datacenter.foobar
            profitbricks_nic.database_nic
        profitbricks_nic.database_nic:
          ID = 0ea56c50-5c80-47f4-a1c3-065f1345b3a6
          provider = provider.profitbricks
          datacenter_id = 4a709c1e-1ace-448e-81ce-c66aa565bed2
          dhcp = true
          firewall_active = true
          ips.# = 1
          ips.0 = 10.12.60.11
          lan = 2
          name = updated
          server_id = e33404a3-60f4-4c39-948f-9e8b3184cc0b

          Dependencies:
            profitbricks_datacenter.foobar
            profitbricks_server.webserver
        profitbricks_server.webserver:
          ID = e33404a3-60f4-4c39-948f-9e8b3184cc0b
          provider = provider.profitbricks
          availability_zone = ZONE_1
          boot_volume = 62131c5a-ab90-4f79-a233-068845a7b474
          cores = 1
          cpu_family = AMD_OPTERON
          datacenter_id = 4a709c1e-1ace-448e-81ce-c66aa565bed2
          image_name = ubuntu-16.04
          image_password = K3tTj8G14a3EgKyNeeiY
          name = webserver
          nic.# = 1
          nic.0.dhcp = true
          nic.0.firewall.# = 0
          nic.0.firewall_active = true
          nic.0.ip = 10.11.130.11
          nic.0.ips.# = 1
          nic.0.ips.0 = 10.11.130.11
          nic.0.lan = 1
          nic.0.name = 
          nic.0.nat = false
          primary_ip = 10.11.130.11
          primary_nic = 2621b875-263d-4adb-bf32-b666ceafff24
          ram = 1024
          ssh_key_path.# = 0
          volume.# = 1
          volume.0.availability_zone = AUTO
          volume.0.bus = VIRTIO
          volume.0.disk_type = SSD
          volume.0.image_aliases.# = 0
          volume.0.image_name = 
          volume.0.image_password = 
          volume.0.licence_type = LINUX
          volume.0.name = system
          volume.0.size = 5
          volume.0.ssh_key_path.# = 0

          Dependencies:
            profitbricks_datacenter.foobar
=== RUN   TestAccProfitBricksNic_Basic
--- PASS: TestAccProfitBricksNic_Basic (322.99s)
=== RUN   TestAccProfitBricksServer_Basic
--- PASS: TestAccProfitBricksServer_Basic (348.14s)
=== RUN   Test_Update
--- PASS: Test_Update (0.00s)
=== RUN   TestAccProfitBricksShare_Basic
--- FAIL: TestAccProfitBricksShare_Basic (70.46s)
    testing.go:579: Error destroying resource! WARNING: Dangling resources
        may exist. The full state and error is shown below.

        Error: Check failed: share for resource  still exists in group  

        State: <no state>
=== RUN   TestAccProfitBricksSnapshot_Basic
--- PASS: TestAccProfitBricksSnapshot_Basic (337.44s)
=== RUN   TestAccProfitBricksUser_Basic
--- FAIL: TestAccProfitBricksUser_Basic (77.04s)
    testing.go:579: Error destroying resource! WARNING: Dangling resources
        may exist. The full state and error is shown below.

        Error: Check failed: user still exists 01a54779-dba0-45cd-ae7e-296d05768517 HTTP Status: 404 
        Error Messages:Error Code: 309 Message: Resource does not exist

        State: <no state>
=== RUN   TestAccProfitBricksVolume_Basic
--- PASS: TestAccProfitBricksVolume_Basic (464.51s)
FAIL
FAIL    github.com/terraform-providers/terraform-provider-profitbricks/profitbricks 4113.215s
make: *** [testacc] Error 1
Ntr0 commented 5 years ago

So the usual suspects fail