search

ionspin / kotlin-multiplatform-bignum

A Kotlin multiplatform library for arbitrary precision arithmetics
Apache License 2.0
345 stars 41 forks source link

Move DecimalUtility to jvmMain #230

Closed BraisGabin closed 2 years ago

BraisGabin commented 2 years ago

This PR is related with this comment: https://github.com/ionspin/kotlin-multiplatform-bignum/discussions/216#discussioncomment-2728051

I don't know which cases should I test here. I saw that toJavaBigDecimal has a lot of useages right now in the tests so maybe that's enoght to test it. If it's not, please, tell me which cases should I tests here.

CLAassistant commented 2 years ago

CLA assistant check
All committers have signed the CLA.

ionspin commented 2 years ago

Looks good, over the weekend I'll make a clone pull request just so gitlab CI can pick this up and once it's done we can merge it. Thanks!