Open hakanai opened 2 years ago
I'm still unsure about the way I handled precision here.
I could have tried to use the precision of the number used as input, but the problem is that the decimal mode can currently be null
, which can't work for these things because they always need to know when to stop.
Also I haven't actually signed the commit, but it isn't a complete solution either, so I'll worry about that if it gets even remotely close to usable. :(
Awesome, thanks for the contribution! It will take me some time to go through it in detail and understand everything so please have patience, especially since I can only get some time to work on the library on the weekend. And don't worry about the signature.
The decimal mode was long overdue for a refactor so I'll try to combine that with changes here.
I haven't forgotten about this, but I'm still short on time. It's top of my priority list for the library.
why isn't it yet merged? any problems with it? Btw, missing precision could be taken from the decimal size of the argument + n, usually it works fairy well. Also you can provide some kind of epsilon parameter instead.
@ionspin could you please merge it or like?
@sergeych Unfortunately I haven't had the time to properly go through this pull request and it's also related to decimal mode refactor which is a big undertaking, so that's why this pull request hasn't been merged for a long time, and by the way things are looking it's going to stay that way for some time to come.
Added:
Not added: