fix ROUND_HALF_TO_EVEN - Githubissues

ionspin / kotlin-multiplatform-bignum

A Kotlin multiplatform library for arbitrary precision arithmetics

Apache License 2.0

339 stars 40 forks source link

fix ROUND_HALF_TO_EVEN #270

Closed CodeServant closed 8 months ago

CodeServant commented 8 months ago

change to absolute value when evaluating the rest from division, because can be either 1 or -1
delete the code that checks decider when decider is already known

Honestly i don't know how this works, please double check this.

CLAassistant commented 8 months ago

All committers have signed the CLA.

CodeServant commented 8 months ago

this solves #269 issue

ionspin commented 8 months ago

Awesome, thanks for the contribution and the tests! JS didn't want to compile because of the test name so I changed that, and I removed the old check for decider which I think you referred to.

This should be available in snapshot as soon as the build completes, which seems to be another issue, since CI/CD is not running it, but I'll take care of that later.

Once again thanks!