ionspin / kotlin-multiplatform-bignum

A Kotlin multiplatform library for arbitrary precision arithmetics
Apache License 2.0
364 stars 42 forks source link

Fix modInverse and or bitwise function #304

Closed iTanChi closed 3 months ago

iTanChi commented 3 months ago

Close issues:

The logic is updated and covered by unit test We have also integrated it with our modules, and it works

CLAassistant commented 3 months ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

:white_check_mark: HoangNguyen219
:x: hieu-dd
You have signed the CLA already but the status is still pending? Let us recheck it.

ionspin commented 3 months ago

Thanks for the pull request, I'll look into it as soon as I have some free time!

ionspin commented 3 months ago

Why is there a github action definition in this pull request?

iTanChi commented 3 months ago

@ionspin our mistake when we want to publish a package for integrating into our module while waiting for your review. We are reverting that commit

ionspin commented 3 months ago

Ok, please clean up/squash the commits and open a new pull request. Thanks!