search

ioof-holdings / redux-dynostore

These libraries provide tools for building dynamic Redux stores.
BSD 3-Clause "New" or "Revised" License
122 stars 15 forks source link

warnings on fresh install #30

Closed stephen-dahl closed 5 years ago

stephen-dahl commented 5 years ago

Is it a bug, feature request or question?

fresh install gives errors

warning " > @redux-dynostore/react-redux-subspace@2.0.0" has incorrect peer dependency "@redux-dynostore/core@^1.0.0".
warning " > @redux-dynostore/react-redux-subspace@2.0.0" has incorrect peer dependency "@redux-dynostore/react-redux@^1.0.0".

Which package(s) does this involve?

    "@redux-dynostore/core": "^2.0.0",
    "@redux-dynostore/react-redux": "^2.0.0",
    "@redux-dynostore/react-redux-subspace": "^2.0.0",
    "@redux-dynostore/redux-subspace": "^2.0.0",

Input Code

yarn add \
  react \
  react-dom \
  react-redux \
  react-redux-subspace \
  redux \
  redux-subspace \
  @redux-dynostore/core \
  @redux-dynostore/react-redux \
  @redux-dynostore/react-redux-subspace \
  @redux-dynostore/redux-subspace

Expected Behavior

no warnings while installing latest version of your packages

mpeyper commented 5 years ago

lerna is supposed to take care of this sort of thing, but maybe there are some issues in our setup or they way it ran when we released?

Anyway, we should fix this up.

mpeyper commented 5 years ago

This should be fixed in v3. Closing now, but please let me know if it's still an issue.