search

ioof-holdings / redux-subspace

Build decoupled, componentized Redux apps with a single global store
https://ioof-holdings.github.io/redux-subspace/
BSD 3-Clause "New" or "Revised" License
312 stars 33 forks source link

TypeError: Object doesn't support property or method 'startsWith' [redux-subspace] #110

Closed TheHolyWaffle closed 5 years ago

TheHolyWaffle commented 5 years ago

Is it a bug, feature request or question?

Bug, exception is thrown in console when using Internet Explorer 11

Which package(s) does this involve?

redux-subspace

Expected Behavior

No exception is thrown.

Current Behavior

The following exception is thrown: TypeError: Object doesn't support property or method 'startsWith'

https://github.com/ioof-holdings/redux-subspace/blob/ac618ea7a6df5371930b6c38cf6a1e570701b39a/packages/redux-subspace/src/actions/isGlobal.js#L10

Possible Solution

Don't use String.prototype.startsWith in order to support older environments

package version(s)
redux 4.0.1
redux-subspace 3.1.0
Internet Explorer 11
mpeyper commented 5 years ago

Happy to accept a PR replacing the call with something more supported.