search

ioof-holdings / redux-subspace

Build decoupled, componentized Redux apps with a single global store
https://ioof-holdings.github.io/redux-subspace/
BSD 3-Clause "New" or "Revised" License
312 stars 33 forks source link

Remove recompose dependency #510

Closed Byron-Wall closed 3 years ago

Byron-Wall commented 3 years ago
Q A
Fixed Issues? Fixes https://github.com/ioof-holdings/redux-subspace/issues/508
Patch: Bug Fix? 👍
Tests Added + Pass? Yes

Adds createDisplayName util to react-redux-subspace, replaces recompose/wrapDisplayName in react-redux-subspace/src/components/parentSpaced.js and react-redux-subspace/src/components/subspaced.js, and adds test file for createDisplayName util. This removes the recompose dependency, which is currently unmaintained and returning a denial-of-service security issue from npm audit

mpeyper commented 3 years ago

Hi @Byron-Wall,

Sorry it's taken a while to get to this review.

The changes itself is fine and I'm happy to accept it, but there is a lot of formatting changes that seem unnecessary for replacing a function (I understand that there are no formatting rules in place to help with that).

I'll merge as-is, but please don't be offended if I add a prettier config and it all gets formatted back again.

Byron-Wall commented 3 years ago

Hey, thanks for the review, Ive been out all week, so the timing has worked out well for me. I am in no way offended if a prettier config changes formatting. Thanks!

Byron-Wall commented 3 years ago

Hey @mpeyper , would it be possible to let me know when you are able to publish this update to NPM?

mpeyper commented 3 years ago

@Byron-Wall Yes, sorry. Plan was to do it yesterday, but had some production issues at work and swamped me.

I'll endeavour to do it today.

mpeyper commented 3 years ago

@Byron-Wall this has been released in v6.2.0 now.

Byron-Wall commented 3 years ago

@mpeyper thanks for releasing/letting me know!