ioos / bio_mobilization_workshop

Marine data mobilization workshop for Biology and Ecosystem Essential Ocean Variables (Bio-Eco EOV) as a Contribution to the UN Decade on Ocean Science for Sustainable Development
https://ioos.github.io/bio_mobilization_workshop/
Other
5 stars 9 forks source link

Update schema & extensions page #109

Closed EliLawrence closed 3 months ago

EliLawrence commented 4 months ago
MathewBiddle commented 3 months ago

The changes look good. I want to build this locally before we merge to make sure the MD -> Jekyll works as expected.

MathewBiddle commented 3 months ago

Everything build and functions as expected. Thanks @EliLawrence!

I'm curious about the removal of the event and occurrence core table dropdowns. I'm curious about your thought process on removing those tables. Is it because some of that material is presented in the introduction?

Here is the section on the current page: image

Here is the changed page: image

I think I liked having all of them for reference in that page, but it does make the page much bigger.

EliLawrence commented 3 months ago

@MathewBiddle someone on the team suggested to remove those tables from the page because they are listed earlier, but I think having them all together on one page for quick review isn't a bad idea. Can we reject the removal of the tables but keep the others?

MathewBiddle commented 3 months ago

Can we reject the removal of the tables but keep the others?

Let me try something...

MathewBiddle commented 3 months ago

I think I did it:

image

I used pycharm to compare your PR with the gh-pages branch then used the accept feature to merge back in the original tables image very convoluted and probably more clear to just copy and paste from the source. But, I learned something today 🤷

MathewBiddle commented 3 months ago

Merging. Take a look in ~5 minutes to see the changes on the website.