Closed EliLawrence closed 3 months ago
The changes look good. I want to build this locally before we merge to make sure the MD -> Jekyll works as expected.
Everything build and functions as expected. Thanks @EliLawrence!
I'm curious about the removal of the event and occurrence core table dropdowns. I'm curious about your thought process on removing those tables. Is it because some of that material is presented in the introduction?
Here is the section on the current page:
Here is the changed page:
I think I liked having all of them for reference in that page, but it does make the page much bigger.
@MathewBiddle someone on the team suggested to remove those tables from the page because they are listed earlier, but I think having them all together on one page for quick review isn't a bad idea. Can we reject the removal of the tables but keep the others?
Can we reject the removal of the tables but keep the others?
Let me try something...
I think I did it:
I used pycharm to compare your PR with the gh-pages branch then used the accept feature to merge back in the original tables very convoluted and probably more clear to just copy and paste from the source. But, I learned something today 🤷
Merging. Take a look in ~5 minutes to see the changes on the website.