search

ioos / bio_mobilization_workshop

Marine data mobilization workshop for Biology and Ecosystem Essential Ocean Variables (Bio-Eco EOV) as a Contribution to the UN Decade on Ocean Science for Sustainable Development
https://ioos.github.io/bio_mobilization_workshop/
Other
5 stars 9 forks source link

Speed up build time for webpage #77

Closed MathewBiddle closed 1 year ago

MathewBiddle commented 1 year ago

Build time takes a bit to publish site updates (~3 mins). We probably don't need all the RMarkdown stuff...

https://github.com/ioos/bio_mobilization_workshop/blob/6bb30392b6a5ba04dbcec5a0667bae5bb2c992f3/.github/workflows/website.yml#L44-L89

7yl4r commented 1 year ago

There isn't any executable code, right? It is all just markdown rendering that is needed. Since we are using R to render I think we still need R around though.

MathewBiddle commented 1 year ago

There isn't any executable code, right?

Correct, no executable code.

Since we are using R to render I think we still need R around though.

That's where I wasn't sure. We render some static R code on the pages, but does that need a full R environment? The way I'm reading the action is that it looks for R markdown documents

https://github.com/ioos/bio_mobilization_workshop/blob/6bb30392b6a5ba04dbcec5a0667bae5bb2c992f3/.github/workflows/website.yml#L44-L47

which we don't have any:

https://github.com/ioos/bio_mobilization_workshop/tree/gh-pages/_episodes_rmd

Looking closer, there are if statements in the action which skip the R stuff if there aren't .rmd files. For example, https://github.com/ioos/bio_mobilization_workshop/actions/runs/4757453050/jobs/8454289924#step:7:1

The big time sucks are:

7yl4r commented 1 year ago

Those are (1) jekyll installation steps, (2) jekyll rendering steps. They are essential for turning the md into html.

MathewBiddle commented 1 year ago

Not much we can do about it then. 🤷