search

ioos / catalog

IOOS Catalog general repo for documentation and issues
https://ioos.github.io/catalog/
MIT License
2 stars 6 forks source link

CKAN 2.8 Upgrade #65

Closed benjwadams closed 5 years ago

benjwadams commented 6 years ago

Upgrade the version of CKAN to 2.8. Because of the changes in the base CKAN Dockerfile, this will also require rewriting of CKAN's Docker setup.

benjwadams commented 6 years ago

Current WIP branch is here with a compose file under

https://github.com/ioos/ckan/blob/new_compose_test/contrib/docker/docker-compose.yml

Known issues so far (will create separate issues for tracking purposes):

Styling seems broken on home page after upgrades

ckanext-spatial had some custom extensions made to the metadata model on the IOOS branch -- these will need to be brought up to date with the current branch or refactored to make a class which extends the original metadata model somehow. Extensions rebased against CKAN extension master branch.

Pagination styling CSS (for navigating through datasets, etc) appears not to be applying.

benjwadams commented 6 years ago

Changing back to using Bootstrap 2 and associated templates fixed the wonky styling problems. Apparently CKAN 2.8 went to using Bootstrap 3 as a default and it initially caused all the custom templates to look out of whack. Reverting to the Bootstrap 2 templates/CSS fixed things.

http://docs.ckan.org/en/2.8/maintaining/configuration.html#ckan-base-templates-folder

benjwadams commented 6 years ago

@mwengren: I have a draft version of the new branch here with updated README including build instructions. https://github.com/ioos/catalog-docker-base/tree/new_ckan_version_draft You're free to attempt building catalog if you want.

It uses a custom CKAN branch with some mostly Docker build related changes as a submodule. The approach may seem a little strange, but it is a lot easier than the current production build process where we have to go through a bunch of different repos and rebuild many images every time there is a change.

I hope to have the changes deployed to a dev server in the next week or so in order to test harvesting, the frontend components, etc.

benjwadams commented 5 years ago

@mwengren: I was able to fix the issues with the dropdown menus not operating and pagination CSS/display. I believe the latter may be a bug/omission in newer versions of CKAN when using the legacy Bootstrap 2 templates, so I may make a bug report to CKAN. Tomorrow I will merge the new CKAN version branches into master, tag things for release, etc and we should be good to close this issue and the milestone soon thereafter.

mwengren commented 5 years ago

@benjwadams, things are looking good. The only remaining UI issue I noticed this morning was that the draw icon is missing from the Leaflet map. See screenshot. Resource dropdowns and pagination controls look better.

Screenshot from 2018-09-26 09-13-35.png

benjwadams commented 5 years ago

@mwengren I am unable to replicate the above issue with the map. Since the new version is now deployed to the production site, could you see if it's working on data.ioos.us for you? map_icon_ff_63

mwengren commented 5 years ago

ok, yeah, it's working for me now. Maybe it was an SSL thing with the self-signed cert, I don't know. I think we can call that issue closed now.

benjwadams commented 5 years ago

Closing this out as I now have a release and all major issues appear addressed.