ioos / ckanext-ioos-theme

IOOS Catalog as a CKAN extension
GNU Affero General Public License v3.0
7 stars 14 forks source link

Update broken image and add feedback button to left side of screen #182

Closed gitchrisadams closed 5 years ago

gitchrisadams commented 6 years ago

image

Broken image fixed: Issue: https://github.com/ioos/catalog-ckan/issues/178 image

Currently the feedback link on left links to the current feedback form. I'm waiting on a comment I posted here: https://github.com/ioos/ioos-us/issues/169#event-1580263855 before this PR should be approved/merged.

mwengren commented 6 years ago

Sorry for the delay to comment. We have a sort of confusing situation with the feedback buttons on the Catalog at the moment, and I'm not sure how much it's worth fixing things now, since we'll be updating CKAN versions at some point in the future and that may affect everything including the front end look and feel code etc.

We have two feedback buttons/forms for Catalog, one which is general (on the top blue nav bar) and one which is dataset specific (less visible on dataset pages). If we could somehow replace both of those with the left button, but have different effect depending on the visible page, that would be ideal.

So, if a user is on a dataset detail page or a related resource page for a dataset (click on the 'Get more information' links under Explore button from any of the items listed under Data and Resources), they would go to the dataset feedback form (which submits add'l info about the dataset they are on), but if they're on any other page in CKAN (like search results, organizations, etc), they get the generic feedback form without the Dataset in the title, and without the additional dataset info included in the email.

We could remove both existing buttons and just keep the left red button, if the above could be done. Hopefully that all makes sense.

catalog_dataset_view