search

ioos / ckanext-ioos-theme

IOOS Catalog as a CKAN extension
GNU Affero General Public License v3.0
7 stars 14 forks source link

Date/Time/Depth filters invalidate existing faceted filters #244

Closed mwengren closed 7 months ago

mwengren commented 1 year ago

Issue 1: To reproduce:

  1. navigate to https://data.ioos.us/dataset
  2. filter by Organization: Glider DAC (you should get ~2480 datasets and a filter tag at the top of the results labeled 'Organization: Glider DAC')
  3. enter a Start Time filter in the Date/Time Selection field (eg 2023-05-01T00:00Z)
  4. hit Apply (you should now see ~2400 datasets and the 'Organization: Glider DAC' filter removed)

Filters should be additive. This used to work in CKAN < 2.9. Something must have regressed between versions.

Also, it would be great if there were some way for the Date/Time and Depth filter queries to have labels similar to how the faceted filters work (if possible). We have an issue for this: https://github.com/ioos/catalog-ckan/issues/206.

Issue 2 Free text query and Date/Time/Depth query: Second, similar issue, is that if you enter a free text query in the search bar at the top of the datasets list, the Date/Time/Depth filter criteria are invalidated. Faceted filters, however, are not (eg. Organization: Glider DAC). Seems the problem is that Date/Time/Depth filter logic is applied independently of the other UI controls, where it should be integrated.

mwengren commented 1 year ago

We also noted on 6/5 this one could be investigated by @nguyandy, potentially. Tagging here for reference purposes.

mwengren commented 7 months ago

Looks good now!