search

ioos / compliance-checker-web

Web-based front-end for the IOOS Compliance Checker project
https://compliance.ioos.us
MIT License
5 stars 10 forks source link

Different Results for .cdl and .nc files #111

Closed daltonkell closed 4 years ago

daltonkell commented 4 years ago

Current Status

@neumannd brought up an issue in the Compliance Checker repository (https://github.com/ioos/compliance-checker/issues/831) which states that a .cdl file supplied to both the command line tool and the web tool produce different results. Additionally, when the .cdl is given to the web checker, the dimensions that show up on the file which the checker said it used are different than the input. For example:

CDL input:

netcdf example_header_atmodat_standard { 
 dimensions: 
        time = UNLIMITED ; // (25 currently) 
        nv2 = 2 ; 
        nv4 = 4 ; 
        y = 106 ; 
        x = 112 ; 
        z = 1 ; 
 variables: 
        double time(time) ;
...

CC Web CDL output:

netcdf uploaded-file {
dimensions:
    time = 1 ;
    nv2 = 1 ;
    nv4 = 1 ;
    y = 1 ;
    x = 1 ;
    z = 1 ;

Proposed Solution

Note here

https://github.com/ioos/compliance-checker-web/blob/d9b90b3eb4ae3cbda9e3c935160d988f53370af7/cchecker_web/upload.py#L97-L111

on line 108, we see that the dimensions of the .cdl file are updated with another function. THis function changes all the dimensions to be 1:

https://github.com/ioos/compliance-checker-web/blob/d9b90b3eb4ae3cbda9e3c935160d988f53370af7/cchecker_web/upload.py#L114-L139

Removing this function will no longer change the .cdl file.

daltonkell commented 4 years ago

Addressed by #112