search

ioos / erddapy

Python interface for ERDDAP
https://ioos.github.io/erddapy/
BSD 3-Clause "New" or "Revised" License
77 stars 30 forks source link

started griddap notebook #193

Closed callumrollo closed 3 years ago

callumrollo commented 3 years ago

This will eventually close #191 need to figure out how the notebook becomes part of the documentation first though

review-notebook-app[bot] commented 3 years ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

callumrollo commented 3 years ago

Same problem with failing tests over here, independent commit, not even touching the erddapy code. Something must be up with the CI

ocefpaf commented 3 years ago

I opened an issue upstream to track this. See https://github.com/s-weigand/setup-conda/issues/125

s-weigand commented 3 years ago

I just release v1.0.7, so using s-weigand/setup-conda@v1 should be fine again. Thanks again for reporting the issue and testing the fix branch ❤️

callumrollo commented 3 years ago

@ocefpaf the notebook is still pretty detail-light, but it covers essential griddap functionality, including a plot and how to skip the sub-setting by using opendap.

If I've got the sphinx integration right, I think we're about done with this PR

callumrollo commented 3 years ago

All green lights bay-beee!

callumrollo commented 3 years ago

Is it ok for me to add GSoC labels? Feels kinda like marking my one homework...

ocefpaf commented 3 years ago

Is it ok for me to add GSoC labels? Feels kinda like marking my one homework...

Please do! I may forget. Also, that is not marking, the marking comes after ;-p

ocefpaf commented 3 years ago

@callumrollo I messed up the rebase b/c I still had a master branch and pulled stuff from it. Sorry! Do you mind re-sending this PR? It is probably the cleanest way to preserve your commits/authorship here.

callumrollo commented 3 years ago

No worries @ocefpaf, I'll do that now