search

ioos / erddapy

Python interface for ERDDAP
https://ioos.github.io/erddapy/
BSD 3-Clause "New" or "Revised" License
77 stars 30 forks source link

try latest mypy #195

Closed ocefpaf closed 3 years ago

ocefpaf commented 3 years ago

Latest mypy does not install all stub by default and installing them in the conda env is not "visible" in for the pre-commit interpreter. Let's see if we can make it work with this setup.

ocefpaf commented 3 years ago

@callumrollo I reported the prenotebook failure upstream. See https://github.com/deathbeds/prenotebook/issues/6

callumrollo commented 3 years ago

Cool. Though it's weird it only fails for some PRs. e.g. #193 is passing atm

ocefpaf commented 3 years ago

Cool. Though it's weird it only fails for some PRs. e.g. #193 is passing atm

I think you nailed it. That one is passing b/c it has a notebook. I guess it is not smart enough to not run when it shouldn't.