Remove Pandas FutureWarning

[vinisalazar]

Hi,

Problem

When running ERDDAP.griddap_initialize, I would get the following warning: FutureWarning: The frame.append method is deprecated and will be removed from pandas in a future version. Use pandas.concat instead. My Pandas version is 1.4.0.

Proposed solution

If merged, this PR will modify the _griddap_get_constraints function in order to remove the Pandas FutureWarning that was introduced in the latest Pandas versions.

I ran Pytest, Pre-Commit, and tested the function locally (by running ERDDAP.griddap_initialize), and things seem to be working properly.

Summary of changes:

• Replace frame.append() with pd.concat()
• Replace table.index = with .set_index(drop=True)
• Format code with Black

Thank you for any assistance you can provide,

Vini

[vinisalazar]

Update: just did some more checks and this introduces some bugs. Will investigate further and push to this PR.

[vinisalazar]

Fixed with f94c9b8. Had forgotten to overwrite the new table variable.

[ocefpaf]

@vinisalazar is this one ready for review?

[vinisalazar]

Yes, thank you for the reminder!

[vinisalazar]

@ocefapf apologies for missing your comment about the nesting. Thank you for the review and merge!

[ocefpaf]

No problem. I'm doing some housekeeping to get ready for GSoC and went ahead with this one. Hope to see more PRs from you in the future ;-p