ioos / erddapy

Python interface for ERDDAP
https://ioos.github.io/erddapy/
BSD 3-Clause "New" or "Revised" License
77 stars 30 forks source link

Impossible to import erddapy with pandas 2.0 #299

Closed gmaze closed 1 year ago

gmaze commented 1 year ago

I was building a conda environment with unpinned packages:

When conda/mamba solve this, it peaks the Pandas version 2.0 from which erddapy is trying to import parse_time_string from pandas._libs.tslibs.parsing but the parse_time_string function is not longer available there (apparently it was removed after v2.0.0.dev0)

following the function signature, it looks to have been replaced by: parse_datetime_string_with_reso, which was in fact called by parse_time_string code.

May be erddapy could simply rely on py_parse_datetime_string in here ?

this looks like a recurrent issue for erddapy (#128 #34 #240 )

At some point we should probably vendor parse_time_string b/c that is not part of pandas' public API.

ocefpaf commented 1 year ago

this looks like a recurrent issue for erddapy (#128 #34 #240 )

Yep. Time to stop the band-aid and fix for good. Working on it...

ocefpaf commented 1 year ago

For now see https://github.com/conda-forge/conda-forge-repodata-patches-feedstock/pull/426