ioos / glider-dac

The IOOS Glider DAC site/scripts/tools
http://gliders.ioos.us/providers/
10 stars 13 forks source link

Missing standard_names for DAC provided QARTOD QC variabes #382

Open kerfoot opened 1 month ago

kerfoot commented 1 month ago

I couldn't find an issue template for an issue such as this so I'm submitting it as a general issue....

The compliance checker is reporting missing standard_names for some/all of the QARTOD qc flag variables. Here are the compliance reports for bios_jack-20240812T1810 and ru36-20240821T1852 as examples.

There are standard names for these types of flags in the CF standards.

leilabbb commented 1 month ago

The standard names are in the system, but for the cases you cited, they are missing from the attribute list of the QARTOD variable, which needs further investigation.

For bios_jack-20240812T1810, the flags for density and salinity are missing because the valid_min and valid_max values are switched, causing the netCDF library to interpret them as NaNs.

For ru36-20240821T1852, the QARTOD flags for conductivity, density, and salinity are missing because the standard_names are absent from the list of attributes.

kerfoot commented 2 weeks ago

It looks like there are still issues with standard_name/long_name attributes on QC variables added by the DAC team:

ru36-20240821T1852

I believe at least one additional issue has been submitted by another provider.

What is the status on this?

sarinamann-noaa commented 2 weeks ago

Hi @kerfoot, I will let @leilabbb correct me if I am wrong but I believe that the needed changes have been applied, and at this point we are waiting for the changes to appear in the datasets.

leilabbb commented 2 weeks ago

Yes that is correct. Changes are been applied to datasets. Checkout ERDDAP-ru36-20240821T1852

qartod_density_primary_flag { Byte _FillValue 2; String _Unsigned "false"; String dac_comment "QARTOD TESTS NOT RUN"; String flag_meanings "PASS NOT_EVALUATED SUSPECT FAIL MISSING"; Byte flag_values 1, 2, 3, 4, 9; String ioos_category "Quality"; String long_name "QARTOD Flat Line Test for sea_water_density"; String references "https://gliders.ioos.us/files/Manual-for-QC-of-Glider-Data_05_09_16.pdf"; String standard_name "aggregate_quality_flag"; String units "1"; Byte valid_max 9; Byte valid_min 1; }

The compliance checker needs to run again to reflect changes.

leilabbb commented 2 weeks ago

The errors are still showing up in the compliance check report. The ticket will be closed once the report is updated.