search

ioos / ioos-metadata

Documentation site for the IOOS Metadata Profile
https://ioos.github.io/ioos-metadata
1 stars 9 forks source link

Kbailey noaa patch 2 #22

Closed kbailey-noaa closed 4 years ago

mwengren commented 4 years ago

@kbailey-noaa It looks good. I wonder if we should drop a couple of the bullets in this list since you explain in the text above the partial-harvest aspect, and the following bullet maybe it could be rephrased.

https://github.com/ioos/ioos-metadata/pull/22/files#diff-1c8ac4c7cc1667d221232973e4e351adR486-R490

Ugh, not sure the link above really makes it obvious, I'm talking about lines 486 - 490 in the markdown file that include the bullet points:

Also perhaps change GTS to NDBC/GTS in the bullet list header as well?

We can either do that as part of this PR if you edit the same branch, or can do it afterwards, either way.

kbailey-noaa commented 4 years ago

@mwengren Yes, good catch. I missed that section.
Changes - 1) Change GTS to NDBC/GTS in the bullet list header 2) Drop the 2nd bullet ("Some of the data that NDBC pulls never makes it ...") 3) I don't see it stated anywhere else that "If you set gts_ingest on a variable the NDBC doesn’t care about, NDBC will just ignore it." It's a good point, worth making but I'd like to rephrase to: ""If you set gts_ingest on a variable the NDBC doesn’t currently accept, NDBC will just ignore it."

What do you think?

mwengren commented 4 years ago

@kbailey-noaa Sounds good, will make changes. I think the 'care about' phrasing was more what I was looking to change in third bullet as well. Will merge this and change those afterward.