search

ioos / ioos-metadata

Documentation site for the IOOS Metadata Profile
https://ioos.github.io/ioos-metadata
1 stars 9 forks source link

Add initial gold standard examples #3

Closed jessicaaustin closed 5 years ago

mwengren commented 5 years ago

@jessicaaustin Looks like a great start! I like the reorganization of the 1.2 guidance into categories.

I'm wondering what to do about the WMO ID guidance and if we choose to make changes to accommodate the OceanSITES wmo_platform_code per Kevin's suggestion, how to incorporate into the guidance, because it would complicate the recommended|required rules significantly. We can discuss tomorrow.

Thanks for getting this started.

jessicaaustin commented 5 years ago

@mwengren Yeah, the WMO code aspect definitely should be in here. But I think it can be a separate PR? We haven't even nailed down what it should say yet. :)

We should give @kwilcox a chance to review first, but would you be ok with merging this? I think it'll be helpful for our discussion tomorrow.

mwengren commented 5 years ago

Happy to merge whenever, it is a big improvement. I'll let @kwilcox review first, and I'm actually not sure what happens in this case, but did you see my comment above on a code example error? Do I need to change that before I merge, or will it be automatically merged. Never used the code suggestion feature before.

mwengren commented 5 years ago

@jessicaaustin I also noticed item 5 and 6 in the caveats are redundant now (I had added 6 a few weeks ago when I saw you started working on them). Can you remove that in your branch before merge?

kwilcox commented 5 years ago

@jessicaaustin I also noticed item 5 and 6 in the caveats are redundant now (I had added 6 a few weeks ago when I saw you started working on them). Can you remove that in your branch before merge?

Fixed (removed 5)

mwengren commented 5 years ago

@kwilcox I think maybe we want 5 instead of 6? IDK. I can go ahead and merge and we can fix again later if necessary.