search

ioos / ioos_metrics

Working on creating metrics for the IOOS by the numbers
https://ioos.github.io/ioos_metrics/
MIT License
2 stars 4 forks source link

Move away from direct commits #65

Closed ocefpaf closed 5 months ago

ocefpaf commented 5 months ago

A workflow won't trigger another one to avoid the creating recursive workflow runs. We can create a PR though, which would trigger the other workflow on merge and allow for the possibility of a content inspection too.

Closes https://github.com/ioos/ioos_metrics/issues/29

ocefpaf commented 5 months ago

@MathewBiddle someone with admin rights will need to enable Actions to send PRs. See https://github.com/peter-evans/create-pull-request?tab=readme-ov-file#workflow-permissions

Note that we should not run one in PRs, just scheduled or workflow dispatch. (I'm not sure if it even works from a PR.)

The alternative to this would be to create a PAT and allow a workflow to triggers another workflow. I do not recommend that b/c IMO, having to merge a PR is always safer than commiting directly.

MathewBiddle commented 5 months ago

I think permissions are OK? image

ocefpaf commented 5 months ago

Do you want to merge and test it?

MathewBiddle commented 5 months ago

seems to have worked https://github.com/ioos/ioos_metrics/pull/66

ocefpaf commented 5 months ago

seems to have worked #66

Nice! Let's see if it behaves well not 😬 We don't want tons of PRs due to false diffs.