search

ioos / ioos_metrics

Working on creating metrics for the IOOS by the numbers
https://ioos.github.io/ioos_metrics/
MIT License
2 stars 4 forks source link

starting mbon_stats #74

Closed MathewBiddle closed 1 month ago

MathewBiddle commented 1 month ago

Starting to add the mbon_stats function to this library

@laurabrenskelle @ocefpaf

MathewBiddle commented 1 month ago

@ocefpaf this introduces pyobis as a dependency. I added to environment.yml but not the lock files. I assume that will break things.

ocefpaf commented 1 month ago

@ocefpaf this introduces pyobis as a dependency. I added to environment.yml but not the lock files. I assume that will break things.

It won't break things but if when we do add a test for this functionality we need to update the conda-lock file with:

conda-lock --conda=micromamba -f environment.yml

then commit the new conda-lock file.

MathewBiddle commented 1 month ago

@ocefpaf mind taking a look?

MathewBiddle commented 1 month ago

Thanks! Yeah, that sounds good. We'll need help with tests...

MathewBiddle commented 1 month ago

okay! We should be ready to merge! :)

ocefpaf commented 1 month ago

okay! We should be ready to merge! :)

I don't have merge rights here but I agree! Merge away!!

MathewBiddle commented 1 month ago

@laurabrenskelle mind merging?