ioos / ioos_qc

:ballot_box_with_check: :ocean: IOOS QARTOD and other Quality Control tests implemented in Python
https://ioos.github.io/ioos_qc/
Apache License 2.0
42 stars 27 forks source link

GSoC: Clarification on QC Checks Implemented in argo.py #112

Open Sakshamgupta90 opened 1 month ago

Sakshamgupta90 commented 1 month ago

Hi, @ocefpaf @MathewBiddle @mwengren As I delve deeper into the project, I want to clarify that the current state of QC checks for the glider data are implemented in the argo.py file right? Specifically, I am referring to the speed test and pressure increasing test for glider data.

Your guidance will help me understand the current implementation better and identify areas for improvement.

ocefpaf commented 1 month ago

They are probably the same, if not very close with different defaults that we can factor in and re-use the same function.

Here we are in a complicated territory b/c we don't want to change the API but we also don't want to have a lot of code duplication. Soo we will also have another moving platform to deal with, animal telemetry, that will have similar test.

With that said, here is a suggestion, we could create a new module named moving_platforms.py, move these common tests there, and import them into the argo.py module to avoid breakage but also keeping them available in for other modules to import from.

What do you think @iwensu0313?

PS: Note that, all the glider tests you will implement, should probably go into the qartod.py module b/c they are part of qartod. That means anything you implement in this new moving_platforms.py, should be imported that as well and added to the __all__ variable.