search

ioos / ioos_qc

:ballot_box_with_check: :ocean: IOOS QARTOD and other Quality Control tests implemented in Python
https://ioos.github.io/ioos_qc/
Apache License 2.0
46 stars 27 forks source link

Support relative time Climatology tests and standardize time inputs #21

Closed kwilcox closed 4 years ago

kwilcox commented 4 years ago

Fixes #16 and #19.

Some pep/flake/deprecation cleanup as well.

jessicaaustin commented 4 years ago

@kwilcox this isn't part of your PR but I noticed it because of one of the tests you added. If a climatology isn't defined for the given time range (and/or depth), then we mark it as qc flag MISSING:

https://github.com/ioos/ioos_qc/blob/b7030748e041720ee14708f68ef42a9ba27114d5/ioos_qc/qartod.py#L360

Shouldn't that be NOT EVAL instead? The data isn't missing, we just didn't run tests there because they weren't defined for that time/depth.

kwilcox commented 4 years ago

@kwilcox this isn't part of your PR but I noticed it because of one of the tests you added. If a climatology isn't defined for the given time range (and/or depth), then we mark it as qc flag MISSING:

https://github.com/ioos/ioos_qc/blob/b7030748e041720ee14708f68ef42a9ba27114d5/ioos_qc/qartod.py#L360

Shouldn't that be NOT EVAL instead? The data isn't missing, we just didn't run tests there because they weren't defined for that time/depth.

I agree!