ioos / ioos_qc

:ballot_box_with_check: :ocean: IOOS QARTOD and other Quality Control tests implemented in Python
https://ioos.github.io/ioos_qc/
Apache License 2.0
46 stars 27 forks source link

Improvements to how `NcQcConfig` handles dimensions in netcdf file #31

Open jessicaaustin opened 4 years ago

jessicaaustin commented 4 years ago

When running tests on a netcdf file with NcQcConfig, you must pass in the names of the dimension variables (time, depth, lat, lon, etc) to the constructor.

It would be better to define those dimensions within the config object itself.

And it would be even better if the config could use CF conventions to pick out the dimensions from the file metadata itself.

See https://github.com/ioos/ioos_qc/pull/27#issuecomment-586463722 for background and discussion.