Bug in creating a climatology with data that spans different years

ioos / ioos_qc

:ballot_box_with_check: :ocean: IOOS QARTOD and other Quality Control tests implemented in Python

https://ioos.github.io/ioos_qc/

Apache License 2.0

46 stars 27 forks source link

Bug in creating a climatology with data that spans different years #51

Closed kwilcox closed 3 years ago

kwilcox commented 3 years ago

See https://github.com/ioos/ioos_qc/blob/valid-range-test/ioos_qc/config_creator/config_creator.py#L397-L399

Changing this notebook's query_min_t to be in 2020 will expose the bug. The end dates end up being before the start dates and no data is returned in the subset.

yosoyjay commented 3 years ago

Improvement in the handling of interpolation including a fix for this issue in 5c80088

kwilcox commented 3 years ago

Fix in https://github.com/ioos/ioos_qc/commit/5f41cc7c7e42324d31095c7c2a8f5b68c4eb23d4