ioos / ioos_qc

:ballot_box_with_check: :ocean: IOOS QARTOD and other Quality Control tests implemented in Python
https://ioos.github.io/ioos_qc/
Apache License 2.0
46 stars 27 forks source link

Fixed spike test masked array issue #62

Closed przybytek closed 3 years ago

przybytek commented 3 years ago

Fixed issue in spike_test where the ref array was not getting initialized as a masked array. This was causing some values that should result in a masked restult to use the underlying value stored in the masked array to be using in the calculation resulting in incorrect results.

For example, with the following input: [101, 102, --, 104, 105] The resulting output should be: [2, 9, 9, 9, 2] However, with the ref array initialized as a non masked array the following is the result: [2, 1, 9, 9, 2]

The affected tests were also updated to reflect the correct behavior.

kwilcox commented 3 years ago

Thanks!