search

ioos / ioos_qc

:ballot_box_with_check: :ocean: IOOS QARTOD and other Quality Control tests implemented in Python
https://ioos.github.io/ioos_qc/
Apache License 2.0
46 stars 27 forks source link

Fix docs #73

Closed ocefpaf closed 1 year ago

ocefpaf commented 2 years ago

This one is built on top of #70 but we should not merge this one yet. I "fixed" so many things that we may need to discuss if all these changes actually make sense.

review-notebook-app[bot] commented 2 years ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

ocefpaf commented 2 years ago

@kwilcox I feel bad for throwing a PR like this on you. Many commits, multiple "fixes" that makes the docs pass but doesn't really review them as I should, etc. However, I promise I'll find some time to properly review the docs in a future PR. At the moment, getting them to build and pass is what I can do :grimacing:

ocefpaf commented 1 year ago

@kwilcox this PR makes the docs pass but doesn't mean we want everything we have here. I'll send smaller PRs with the fixes specific problems to make it easier to review. Keeping this draft just as a reference.

kwilcox commented 1 year ago

@ocefpaf ready for review again?

ocefpaf commented 1 year ago

@ocefpaf ready for review again?

Not yet. I'm planning on decoupling the notebook changes from the rest to make it easier to review. Rebasing here just to make sure everything is passing before sending the non-notebook PR.