ioos / ioos_qc

:ballot_box_with_check: :ocean: IOOS QARTOD and other Quality Control tests implemented in Python
https://ioos.github.io/ioos_qc/
Apache License 2.0
46 stars 27 forks source link

update for xarray new map_index_queries #78

Closed ocefpaf closed 2 years ago

ocefpaf commented 2 years ago

Closes #77

@kwilcox any chance this will get me some credit and a review on #71 and #75 :stuck_out_tongue_winking_eye:

ocefpaf commented 2 years ago

This PR makes it py>=38 only. I can push and alternative that makes it py>=36 if you think it is useful.

kthyng commented 2 years ago

@ocefpaf including Python 3.7 would be useful for me

ocefpaf commented 2 years ago

@ocefpaf including Python 3.7 would be useful for me

Latest commit re-adds it. I added some comments on the code that needs to be removed when dropping 3.7

kwilcox commented 2 years ago

:laughing: on a random computer without pre-commit installed. The shame I feel is immense.