numpy >=1.23 causes the tests to segfault

ioos / ioos_qc

:ballot_box_with_check: :ocean: IOOS QARTOD and other Quality Control tests implemented in Python

https://ioos.github.io/ioos_qc/

Apache License 2.0

42 stars 27 forks source link

numpy >=1.23 causes the tests to segfault #86

Closed ocefpaf closed 1 year ago

ocefpaf commented 1 year ago

I narrowed it down to the spline call in:

https://github.com/ioos/ioos_qc/blob/093935e0f2c21a6a585bda5a194fc7a2c7aedd76/ioos_qc/config_creator/config_creator.py#L507

y_no_nans is an array like,

array([], shape=(13, 0), dtype=float64)

I'm not sure if that is the correct way to test this. Even though it was passing before it looks like spline should not work here b/c y should be finite numbers.

ocefpaf commented 1 year ago

Fixed in #88

xref in case something changes upstream: https://github.com/scipy/scipy/issues/17241