ioos / ioos_qc

:ballot_box_with_check: :ocean: IOOS QARTOD and other Quality Control tests implemented in Python
https://ioos.github.io/ioos_qc/
Apache License 2.0
42 stars 27 forks source link

Rate of change test no fail threshold #93

Open callumrollo opened 1 year ago

callumrollo commented 1 year ago

More of a query. Why is it that ioos_qc.qartod.spike_test takes both a fail threshold and suspect threshold, while ioos_qc.qartod.rate_of_change_test takes only threshold, which flags data as suspect?

ocefpaf commented 1 year ago

I believe that is specified in the QARTOD manuals. My guess is that rate_of_change_test is complicated and can lead to many false positives, while a spike_test is almost a confirmation of the rate_of_change_test failure.