Closed kwilcox closed 2 years ago
@kerfoot Could you weigh in here?
To the best of my knowledge there is no standard that describes an attribute type
for an instrument variable. And I don't think it's used for anything by NODC for archiving. So, it can probably be a free-form attribute, but I'd like John to weigh in.
Glider DAC plugin for the CC requires it:
Corrective Actions
Name Priority Corrective action
Container Variables 2 instrument_ctd variable is missing required attribute type
Correct, it requires it but it doesn't care what's inside the attribute, so you can set it to whatever you want.
Kyle,
I think you're right. It should probably be set to instrument, not platform.
John
On Thu, Sep 15, 2016 at 12:46 PM, Luke Campbell notifications@github.com wrote:
Correct, it requires it but it doesn't care what's inside the attribute, so you can set it to whatever you want.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ioos/ioosngdac/issues/109#issuecomment-247384124, or mute the thread https://github.com/notifications/unsubscribe-auth/ACpmrdyL5U0WDv-hRbs3mzgX-2kBEMRxks5qqXaAgaJpZM4J-Ap- .
@kwilcox you can go ahead and set instrument_ctd:type = "instrument";
good catch. We'll update the wiki with our next round of edits.
I'd like to leave this issue open until the wiki is updated. The gliderDAC plugin doesn't check attribute contents, so we should be ok on that front.
Migrating towards standardized vocabularies for instrument, platforms, institutions, etc. Closing.
Here it gives the example attribute
instrument_ctd:type = "platform" ;
. Is this correct? I was expectinginstrument_ctd:type = "instrument" ;
.