search

ioos / ioosngdac

IOOS National Glider Data Assembly Center (V2)
https://ioos.github.io/ioosngdac/
8 stars 18 forks source link

`valid_min` and `valid_max` not set to the correct type on some variables #117

Closed kwilcox closed 6 years ago

kwilcox commented 7 years ago

The valid_min and valid_max attributes should be of the same type as the data variable but this is not always the case with data coming from the DAC:

https://data.ioos.us/gliders//thredds/dodsC/deployments/mbari/UCSC260-20150520T0000/UCSC260-20150520T0000.nc3.nc.html

All of the _qc variables are offending. I didn't scan all of the datasets, it may occur on more.

kwilcox commented 7 years ago

Here is another: https://data.ioos.us/gliders//thredds/dodsC/deployments/lfiorentino/gichigami-20110630T2049/gichigami-20110630T2049.nc3.nc.html

The attributes are actually strings here... making it harder to figure out what it is suppose to be than the original example.

lukecampbell commented 7 years ago

Ok thanks. It's on our sprint this week to find all the datasets that have valid_min and valid_max issues and we'll reach out to the data providers to fix.

Thanks for finding these. We'll expand our search to also look for type inconsistencies as well.

lukecampbell commented 7 years ago

We found the deployments that need to be corrected and we'll be working with the providers to correct these issues.

benjwadams commented 6 years ago

The issue for the datasets mentioned appears to have been fixed. Closing.