search

ioos / ioosngdac

IOOS National Glider Data Assembly Center (V2)
https://ioos.github.io/ioosngdac/
8 stars 18 forks source link

variable_qc:flag_meanings and variable_qc:flag_values #123

Closed britairving closed 7 years ago

britairving commented 7 years ago

There appears to be a duplicate qc flag. flag_values 6 and 7 both correspond to flag_meanings not_used. Do the meanings not_used apply to different processing steps? If so please clarify the difference. Otherwise, how should this be handled in the qc processing, just pick 6?

kerfoot commented 7 years ago

@bkirving Can you paste the link to the lines you're referring to? I will check it out and reply.

britairving commented 7 years ago

https://github.com/ioos/ioosngdac/blob/master/nc/template/IOOS_Glider_NetCDF_v3.0-qartod.cdl

https://github.com/ioos/ioosngdac/wiki/NGDAC-NetCDF-File-Format-Version-2#lon_uv_qc

kerfoot commented 7 years ago

I think you're referring to the flags that end in "qc". If so, we have moved to the qartodflag variables and are no longer using the _qc flags. These flags will remain and will be used to store data provider qc checks.

Please use the qartod_*flag variables if you are applying qartod qc. If not, leave the variable:ancillary_variables attributes empty and the DAC will perform QARTOD checks and append the appropriate variables.

Does this make sense? If not, let me know.

On Fri, Apr 7, 2017 at 6:20 PM, Brita Irving notifications@github.com wrote:

https://github.com/ioos/ioosngdac/blob/master/nc/ template/IOOS_Glider_NetCDF_v3.0-qartod.cdl

https://github.com/ioos/ioosngdac/wiki/NGDAC-NetCDF- File-Format-Version-2#lon_uv_qc

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/ioos/ioosngdac/issues/123#issuecomment-292665633, or mute the thread https://github.com/notifications/unsubscribe-auth/ACpmrSYs6LGdnqIW7Tm6c6AyMakH8KLaks5rtraqgaJpZM4M3T-X .

britairving commented 7 years ago

It does make sense and I was following the discussion during yesterdays DAC webinar.

However, can you still clarify whether the 2 not_used meanings are just a duplicate or I missed something in the documentation? Our processing has additional QA/QC steps and formatting requirements for agency data submission has been different in the past, i.e. not submitting individual files for each profile. Therefore, even though we're moving toward aligning with the DAC I'd like to keep a full qc record over the whole deployment/trajectory and it makes sense to use the old DAC flags.

kerfoot commented 7 years ago

I'm not sure what you mean by "are just a duplicate"? Neither of those flag values are being used which is why they are have the "not_used" string. You are free to define alternate meanings for any flag value that you would like to use. We are just trying to provide guidance to all users when/if they use qc.

britairving commented 7 years ago

That answers my question, thanks.