Refactors templates and adds QC variable attributes

ioos / ioosngdac

IOOS National Glider Data Assembly Center (V2)

https://ioos.github.io/ioosngdac/

8 stars 18 forks source link

Refactors templates and adds QC variable attributes #129

Closed benjwadams closed 7 years ago

benjwadams commented 7 years ago

Refactors template by moving template boilerplate into a loop. Also adds default attributes for a number of QC variables. Requires updated logic from glider-dac repo.

benjwadams commented 7 years ago

Required by https://github.com/ioos/glider-dac/pull/105

kwilcox commented 7 years ago

I would recommend adding both _FillValue and missing_value attributes to maintain backwards and forward compatibility.

I'm also not a fan of assigning the QARTOD flag of 2 for the missing_value. Accessing the data with (most) client libraries is going to mask the data and it will be an extra step before analysis to retrieve the actual flag value of 2.. @rsignell-usgs @ocefpaf @shane-axiom any thoughts?

kerfoot commented 7 years ago

I agree with @kwilcox. The _FillValue should be a value not listed in variable:flag_values