search

ioos / notebooks_demos

Notebook demonstrations and examples
https://ioos.github.io/notebooks_demos/
MIT License
19 stars 19 forks source link

DwC notebook fixes #392

Closed MathewBiddle closed 3 years ago

MathewBiddle commented 3 years ago

Addressing recent comments on #248

review-notebook-app[bot] commented 3 years ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

ocefpaf commented 3 years ago

Teh failures here are unrelated to this notebook. The changes LGTM, merge?

MathewBiddle commented 3 years ago

Yup, should I? I'm never certain on self merging.

ocefpaf commented 3 years ago

Yup, should I? I'm never certain on self merging.

We need at least one review. I asked only to be sure you were not planning on more commits.