search

ioos / notebooks_demos

Notebook demonstrations and examples
https://ioos.github.io/notebooks_demos/
MIT License
19 stars 19 forks source link

Jupyterbook notebook placement #419

Closed lohithmunakala closed 3 years ago

lohithmunakala commented 3 years ago

Deleting old Code Gallery folder structure and adding a new structure based on https://github.com/ioos/notebooks_demos/issues/411.

review-notebook-app[bot] commented 3 years ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

lohithmunakala commented 3 years ago

@ocefpaf @MathewBiddle, the notebooks have some changes because the last time I built the notebooks, each notebook was being run with newer data. The present PR has the notebooks based on the pre-run notebooks. Due to this, there is one change in the notebook cell while compared to the respective older PR ones.

ocefpaf commented 3 years ago

@ocefpaf @MathewBiddle, the notebooks have some changes because the last time I built the notebooks, each notebook was being run with newer data. The present PR has the notebooks based on the pre-run notebooks. Due to this, there is one change in the notebook cell while compared to the respective older PR ones.

Can you revert that? We cannot inspect the notebooks and some have comments on the data based on the date they run the first time.

lohithmunakala commented 3 years ago

@ocefpaf @MathewBiddle, the notebooks have some changes because the last time I built the notebooks, each notebook was being run with newer data. The present PR has the notebooks based on the pre-run notebooks. Due to this, there is one change in the notebook cell while compared to the respective older PR ones.

Can you revert that? We cannot inspect the notebooks and some have comments on the data based on the date they run the first time.

What I mean to say is, the notebooks are how they are on the -present- demo data centre website.

Because I was building the jupyterbook and running the notebooks in the beginning (before we had the discussion of not running the notebooks), the PR consisted of a change. Now that change has been reverted to its original form. The notebook is as it is supposed to be - unrun.