search

ioos / notebooks_demos

Notebook demonstrations and examples
https://ioos.github.io/notebooks_demos/
MIT License
19 stars 19 forks source link

Cleanup notebooks and resubmit draft PRs #425

Closed MathewBiddle closed 3 years ago

MathewBiddle commented 3 years ago

There are a few notebooks that were in development before we migrated. This ticket is to remind us to clean up the outstanding notebooks and make new PRs. See here.

Some of the formatting is wonky when migrated to JupyterBook (see below). We should:

  1. build JupyterBook locally
  2. review each notebook for formatting errors
  3. fix any issues and submit PR

image

lohithmunakala commented 3 years ago

I just checked this, because JupyterBook follows the Markdown style for comments, the comment on the cell originally were in the "###" heading format. JupyterBook considers this as a heading and makes the size bigger. We can change this heading size.

ocefpaf commented 3 years ago

JB is correct here and the "right" fix should be in the notebook itself. We need to review those one by one :-(

MathewBiddle commented 3 years ago

@ocefpaf should we start cleaning up these draft notebook PR's?

ocefpaf commented 3 years ago

@ocefpaf should we start cleaning up these draft notebook PR's?

The new site is up at https://github.com/ioos/ioos_code_lab, we should "copy" the notebooks from the PRs here and open new ones there. I'll add a list of task in the new repo for this. Let's close this one and work there: https://github.com/ioos/ioos_code_lab/issues/4