search

ioos / pyoos

A Python library for collecting Met/Ocean observations
GNU Lesser General Public License v3.0
34 stars 33 forks source link

USGS tests failing #22

Closed daf closed 10 years ago

daf commented 10 years ago

Noticed locally and on TravisCI that USGS tests are failing:

        # Returns 4 stations: 04044724, 04045500, 04046000, 04056500
>       assert len(collection.elements) == 4
E       AssertionError: assert 3 == 4
E        +  where 3 = len([<paegan.cdm.dsg.features.station.Station object at 0xcc30a10>, <paegan.cdm.dsg.features.station.Station object at 0xcce4810>, <paegan.cdm.dsg.features.station.Station object at 0xcce48d0>])
E        +    where [<paegan.cdm.dsg.features.station.Station object at 0xcc30a10>, <paegan.cdm.dsg.features.station.Station object at 0xcce4810>, <paegan.cdm.dsg.features.station.Station object at 0xcce48d0>] = <paegan.cdm.dsg.collections.station_collection.StationCollection object at 0x7f86d1781cd0>.elements
tests/collectors/test_usgs.py:34: AssertionError

Looks like a station is no longer being reported. I'd think a better test approach would be to lock in a known time range instead of always doing (6 hrs ago .. now).

kwilcox commented 10 years ago

assigned!

kwilcox commented 10 years ago

Looks like the tests passed on 2013-05-30 using the 6 hour window