Nerrs enhancements and fixes

ioos / pyoos

A Python library for collecting Met/Ocean observations

GNU Lesser General Public License v3.0

34 stars 33 forks source link

Nerrs enhancements and fixes #48

Closed emiliom closed 8 years ago

emiliom commented 8 years ago

Added support for optional token/wildcard access (implemented at the CDMO in 2014, but not publicly advertised yet), instead of IP-based access
Changed station lat-lon handling:
- Longitude available as W (positive) value, so needed to convert to negative value
- Implemented get_stations lat-lon handling so the returned values are already float-type, not strings
Corrected some standard_name spelling mistakes
Added missing Depth variable
Miscellaneous, PEP8-oriented cosmetic cleanups

emiliom commented 8 years ago

this string is illegal in python 2.x we should prefix it with u

Thanks, @lukecampbell. I didn't realize that. But note that there were already other units strings like the one I added that you highlighted. See 'Temp', 'ATemp', 'Wdir', and 'CHLA_N'. So I guess those should be prefixed with u, too?

emiliom commented 8 years ago

Finally coming back to this. Looks like I had misunderstood things (in PR#49 comments) and thought @daf had already merged my pull request. That's not the case.

Can someone go ahead and merge my PR while adding a known failure or skip flag to the NERRS tests, as @ocefpaf suggested? I can connect with the NERRS CDMO later on to get an auth token to be used in the tests, encripted into the .travis.yml as @kwilcox described.

Thanks!

ocefpaf commented 8 years ago

@emiliom commits from this PR made into master via #53. Closing this.