search

ioos / pyoos

A Python library for collecting Met/Ocean observations
GNU Lesser General Public License v3.0
34 stars 33 forks source link

Nerrs enhancements and fixes (take 2) #53

Closed ocefpaf closed 8 years ago

ocefpaf commented 8 years ago

I pulled @emiliom changes from #48 and

@emiliom Are you OK with this PR?

emiliom commented 8 years ago

Thanks, @ocefpaf! Looks good to me. Thanks for implementing the units string unicode prefix.

emiliom commented 8 years ago

Looks like this is ready to go, right? @ocefpaf, are you planning to merge it yourself, or waiting for someone else to do that?

ocefpaf commented 8 years ago

I'd appreciate if @kwilcox, @daf, or @lukecampbell could take a look at this and merge. We do not have working tests for this yet, so we could use an extra pair of eyes. (I avoid self-merges as much as I can.)

PS: If you want to test this I can create a conda package from the branch.

kwilcox commented 8 years ago

Assuming the Unicode additions are temporary until we can port to py3?

ocefpaf commented 8 years ago

Assuming the Unicode additions are temporary until we can port to py3?

The u'' is OK on python 3. (It was not in 3.1 I think... Not sure when they changed it back.)

emiliom commented 8 years ago

Thanks, @kwilcox and @ocefpaf! Next week I will share a notebook showing metadata requests and a folium map with the returned sites (demonstrating that longitudes are ok), plus a time series request and plot.

emiliom commented 8 years ago

PS: If you want to test this I can create a conda package from the branch.

@ocefpaf, I'll create a conda env using the new pyoos master branch. Let's wait on a new conda package until we have a new pyoos release?

@ocefpaf does the -lon work? haven't seen that syntax before!

It does work but that was not intentional. I did mean to write -1*lon

That was me, from my original commit. Looks to me like it's a valid 2.7 syntax. Though I probably did it w/o thinking, as one of the few remnants of my distant C past.