search

ioos / pyoos

A Python library for collecting Met/Ocean observations
GNU Lesser General Public License v3.0
34 stars 33 forks source link

Add 'metadata_plus_exceptions' function to return SensorML, plus ServiceExceptions #71

Closed mwengren closed 7 years ago

mwengren commented 7 years ago

Some SOS services do not always successfully return SensorML for all procedures, breaking 'metadata' function.

daf commented 7 years ago

Looks like the build failures here exist outside of the PR too. Can you perhaps add a test?

mwengren commented 7 years ago

About the tests, I looked at what's already available for this class, which is nothing, except for the superclass, which is here I believe?. There are pretty good tests for the subclasses of IoosSweSos though: Coops and Ndbc, so I skipped adding anything to the superclass tests at first. Should there be a new test class created for IoosSweSos?

mwengren commented 7 years ago

@daf I added a simple test class for IoosSweSos that hits the NANOOS SOS service and does some simple checks. A lot of the other tests are still failing, and I don't think I can fix those at this point.

Can we merge this with these tests added?

daf commented 7 years ago

@mwengren this is good, and will do a good job detecting drift of live services vs the pyoos codebase (aka, exactly the reason we have build failures currently, although those are data based and not format/processing based). A level-up on this would be to capture the output of this service to embed in the test codebase as a string and plug it through the parsing pipeline to make sure the parsing is working as intended. I'll merge this though.