search

ioos / pyoos

A Python library for collecting Met/Ocean observations
GNU Lesser General Public License v3.0
34 stars 33 forks source link

hads collector update to support unverified SSL certs #78

Closed emiliom closed 7 years ago

emiliom commented 7 years ago

Added kwargs to hads collect method, to support optional, user-driven verify=False option/argument to be passed to requests (to handle failing HADS SSL cert). Tested successfully.

Implemented only on methods called directly by the collect method. Other requests calls may need to be updated similarly, for completeness and full functionality.

emiliom commented 7 years ago

Should I withdraw the PR and submit a new one, to handle (remove) the unintended changes?

emiliom commented 7 years ago

I added a commit that removed the unintended changes (regressions). It's ready for review on this PR. I tested it on Python 2.7.

As before, only the hads collector file is impacted.

emiliom commented 7 years ago

Has anyone had a chance to review my updated PR from 20 days ago?

FYI, I'm using it operationally (from my pyoos fork) for automated hads data harvesting.

lukecampbell commented 7 years ago

btw, we're in contact with NCO and they're working to fix the certificate issue

daf commented 7 years ago

I'm good with it, I like that it makes the use explicit from the pyoos user, not hidden inside of pyoos itself.

@lukecampbell ?

emiliom commented 7 years ago

Thanks @daf!

emiliom commented 7 years ago

Great, thanks @lukecampbell!