Fixed DO_pct standard name. Caused problems when creating csv files from

[ebridger]

paegan response object, duplicate dict keys. Also fixed the salinity units, ppt to psu. Checked both in CDMO Manuals and CF standard names table.

[ebridger]

Changed:

'DO_pct' : 'oxygen_concentration_in_sea_water'

to

'DO_pct' : 'fractional_saturation_of_oxygen_in_sea_water

Also fixed salinity units, ppt to psu

[emiliom]

This looks good to me. I'll merge. Thanks @ebridger

[emiliom]

Ok, I won't merge -- I forgot that I'm not admin here.

@ocefpaf, can you merge? BTW, the Travis-CI failures seems to be unrelated. This commit is straightforward.

[emiliom]

Thanks @ocefpaf

[mwengren]

@ocefpaf Thanks. We need to come up with a better plan to keep some eyes on this and some other repositories so PRs like this don't languish. I don't know that we have the bandwidth here.

cc: @Bobfrat @kknee

[ocefpaf]

I find the GitHub feature to request a review helpful with that, or even a "ping" like @emiliom did here.

Although, for this particular repository, I guess that the question is: for how long to we want to maintain pyoos?

[emiliom]

Although, for this particular repository, I guess that the question is: for how long to we want to maintain pyoos?

That would be a topic of broader interest, that ideally should be broadcast to a broader audience; say, the ioos_tech group, and/or the DMAC meeting in May.

[ebridger]

Probably my fault for not "pinging" but it wasn't clear who to ping. BTW I've only ever used the NERRS stuff in pyoos

[Bobfrat]

I just changed my preferences to be notified of all activity on the repo so I'll keep an eye on it

[ocefpaf]

Probably my fault for not "pinging" but it wasn't clear who to ping.

You can use Reviewers option on the top left and see who GitHub suggests.