search

ioos / pyoos

A Python library for collecting Met/Ocean observations
GNU Lesser General Public License v3.0
34 stars 33 forks source link

fix failing tests #85

Closed ocefpaf closed 5 years ago

ocefpaf commented 5 years ago

I want to send another PR with some code changes but I noticed that some of the tests are stale and failing. We should mock most of those but I'm not sure if it is worth fixing this library, it seems to be on life support already.

ocefpaf commented 5 years ago

I no longer have merge powers on IOOS repositories (ping @mwengren). Can you please merge this one @Bobfrat?

Bobfrat commented 5 years ago

I dont have privileges either

ocefpaf commented 5 years ago

I dont have privileges either

Thanks! @mwengren I guess you are the only one that can merge this now.

rsignell-usgs commented 5 years ago

Yep, it looks like only @mwengren or @dpsnowden can merge now. This is wrong, IMHO. IOOS is supposed to be a partnership led by NOAA, not completely controlled by NOAA.

ocefpaf commented 5 years ago

Yep, it looks like only @mwengren or @dpsnowden can merge now. This is wrong, IMHO. IOOS is supposed to be a partnership led by NOAA, not completely controlled by NOAA.

We can create teams with the right permission granularity if security is a concern, but only org owners can do that.

mwengren commented 5 years ago

@rsignell-usgs @ocefpaf Maintaining teams is the right way to do this. We actually do this extensively already, it's just that you both were org admins which grants the rights to do anything with the IOOS org, including delete it. I've already added both of you to the team that has write access to pyoos.

No ill will intended, but it's in our best interest (if not yet required by policy - NOAA or otherwise) to limit the risks of losing our data.

rsignell-usgs commented 5 years ago

@mwengren , okay makes sense.

ocefpaf commented 5 years ago

Thanks @mwengren for restoring our merge rights, @Bobfrat for the review, and @rsignell-usgs for the merge!