search

ioos / system-test

IOOS DMAC System Integration Test project
github.com/ioos/system-test/wiki
The Unlicense
7 stars 14 forks source link

Updates to Scenario 3A #103

Closed kwilcox closed 10 years ago

kwilcox commented 10 years ago

@rsignell-usgs Can you be sure your conda install can run all cells before merging? Thanks!

rsignell-usgs commented 10 years ago

I tried but ran into a problem with building folium as a conda module. Waiting for answer...

birdage commented 10 years ago

@rsignell-usgs i ran in to an issue installing it to conda today from the git link, i had to pull in the source and install it. Pip install wont work because line is not included in that version. im tempted to generate an egg that we can just pull in...

rsignell-usgs commented 10 years ago

@birdage, you can install the latest folium into conda thusly:

pip install git+https://github.com/wrobstory/folium.git

but I was looking to avoid having folks use pip (that's why I was trying to build the conda module)

birdage commented 10 years ago

@rsignell-usgs i was having issues in my conda env doing a pip install with that method for some reason, hence the install from source. i didnt know if anyone else was having a similar issue

rsignell-usgs commented 10 years ago

@birdage , did you have problems with: 

pip install git+https://github.com/wrobstory/folium.git

or were you trying:

pip install git+git@github.com:wrobstory/folium.git
ocefpaf commented 10 years ago

@rsignell-usgs This PR should fix conda build for folium.

It worked for me here: https://binstar.org/ocefpaf/folium

dpsnowden commented 10 years ago

Poke... What is the status of this PR?

rsignell-usgs commented 10 years ago

@kwilcox, folium is listed as git+https://github.com/wrobstory/folium.git#egg=folium in the git requirements, but that won't work for conda. We need 

conda install folium==0.1.2_dev_f7194ad

Also, I don't think rdflib is a requirement, is it?

Finally, is this the desired result of the notebook? 7-9-2014 8-24-53 am

kwilcox commented 10 years ago

@rsignell-usgs Updated with conda requirements file and fixed that lookup_variable bug.

rsignell-usgs commented 10 years ago

Okay, notebook works fine now, and conda-requirements look good. Now just update README.md to reflect the conda build procedure. And remove rdflib from the requirements?

kwilcox commented 10 years ago

I already updated the README.md. I'm not sure what else you want in there. rdflib is required by the "hannah" notebook in the same directory. I'm not sure what that notebook is, so I left it there.

rsignell-usgs commented 10 years ago

Ah, okay, that explains the rdflib requirement. It seems a bit arbitrary to have common specifications for all tests in a particular directory. Would we instead want requirements for each notebook or perhaps common requirements that would run ALL the system tests?

Bobfrat commented 10 years ago

I like the idea of common requirements that way you don't need to run a requirements file every time you want to run a new notebook.