ioos / system-test

IOOS DMAC System Integration Test project
github.com/ioos/system-test/wiki
The Unlicense
7 stars 14 forks source link

Update to the waves extremal analysis notebook #139

Closed Bobfrat closed 10 years ago

Bobfrat commented 10 years ago
Bobfrat commented 10 years ago

View the notebook here

benjwadams commented 10 years ago

In conda_requirements.txt, the pyoos version is not specified. conda's latest version for pyoos as of this posting appears to be 0.61, compared with 0.62 for pip's package.

Attempting to filter using a BBox in 0.61 returns a message that bbox filtering is not implemented.

Here are the lines that create the filter and call the collector: https://github.com/Bobfrat/system-test/blob/extreme_waves/Theme_2_Extreme_Events/Scenario_2A_Coastal_Inundation/Scenario_2A_Extremes_Waves/Scenario_2A_Waves.py#L181-L184

See the diff between 0.6.1 and 0.6.2 for the problem: https://github.com/ioos/pyoos/compare/0.6.1...0.6.2

Perhaps we should bump the pyoos version used by conda to 0.6.2.

benjwadams commented 10 years ago

Runs properly here. @birdage, care to give a quick run through before merging?