search

ioos / system-test

IOOS DMAC System Integration Test project
github.com/ioos/system-test/wiki
The Unlicense
7 stars 14 forks source link

updates on bob's temperature test #173

Closed rsignell-usgs closed 8 years ago

rsignell-usgs commented 10 years ago

@Bobfrat , I didn't get a chance to finish this, but I fixed some stuff and I'm heading on travel. Hopefully you can merge this with your changes.

ocefpaf commented 9 years ago

@rsignell-usgs This PR need a rebase. Are you familiar with that? Do want help and/or want me to do it?

Bobfrat commented 9 years ago

@ocefpaf I think we can close this pull request because I merged the changes into my own PR: https://github.com/ioos/system-test/pull/169

ocefpaf commented 9 years ago

Even better! I just realized that. Question: Do we need the csv files?

Bobfrat commented 9 years ago

Oh wait I didn't see the additional commits from Sep 25! Those havent been merged yet, sorry.

ocefpaf commented 9 years ago

Re-opened until @rsignell-usgs say something about those csv and extra commits. Maybe a new PR with just those changes would be a better (and cleaner) way to proceed.

jkupiec commented 9 years ago

@rsignell-usgs, if you get a chance in the next couple of days,can you respond to @ocefpaf 's comments? Then he can make a decision whether to merge. Thanks.

ocefpaf commented 8 years ago

I am closing this and re-writing this notebook for the blog post.